search

operator-framework / operator-lifecycle-manager

A management framework for extending Kubernetes with Operators
https://olm.operatorframework.io
Apache License 2.0
1.7k stars 542 forks source link

[FLAKE] should clear up the condition in the InstallPlan status that contains an error message when a valid OperatorGroup is created #2636

Open perdasilva opened 2 years ago

perdasilva commented 2 years ago

Description

Failure log

Install Plan when an InstallPlan is created with no valid OperatorGroup present 
  [FLAKY] should clear clear up the condition in the InstallPlan status that contains an error message when a valid OperatorGroup is created
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3194
[BeforeEach] when an InstallPlan is created with no valid OperatorGroup present
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3168
[It] [FLAKY] should clear clear up the condition in the InstallPlan status that contains an error message when a valid OperatorGroup is created
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3194
installplan ip is in phase Installing
Waiting for OperatorGroup(og) to be synced with status.namespaces: []
Waiting for OperatorGroup(og) to be synced with status.namespaces: [ns-pbxsz]
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
installplan ip is in phase Installing
[AfterEach] when an InstallPlan is created with no valid OperatorGroup present
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3252
[AfterEach] Install Plan
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:55
cleaning up ephemeral test resources...
deleting test subscriptions...
deleting test installplans...
deleting test catalogsources...
deleting test crds...
deleting test csvs...
test resources deleted

• Failure [61.185 seconds]
Install Plan
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:54
  when an InstallPlan is created with no valid OperatorGroup present
  /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3160
    [FLAKY] should clear clear up the condition in the InstallPlan status that contains an error message when a valid OperatorGroup is created [It]
    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3194

    Timed out after 60.001s.
    Expected
        <bool>: false
    to be true

    /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3249

    Full Stack Trace
    github.com/operator-framework/operator-lifecycle-manager/test/e2e.glob..func14.16.2()
        /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3249 +0x5ea
    github.com/operator-framework/operator-lifecycle-manager/test/e2e.TestEndToEnd(0xf908f9)
        /home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/e2e_test.go:59 +0x268
    testing.tRunner(0xc000aee340, 0x30045b8)
        /opt/hostedtoolcache/go/1.17.6/x64/src/testing/testing.go:[125](https://github.com/operator-framework/operator-lifecycle-manager/runs/5213210048?check_suite_focus=true#step:4:125)9 +0x102
    created by testing.(*T).Run
        /opt/hostedtoolcache/go/1.17.6/x64/src/testing/testing.go:[130](https://github.com/operator-framework/operator-lifecycle-manager/runs/5213210048?check_suite_focus=true#step:4:130)6 +0x35a
akihikokuroda commented 2 years ago

This is a duplicate to https://github.com/operator-framework/operator-lifecycle-manager/issues/2516. There is no code that handle the case that the opeatorGroup is created after the installPlan creation. By putting a few second sleep between the installplan creation and the operatorgroup createion https://github.com/operator-framework/operator-lifecycle-manager/blob/094ae7bd1111188368e78ce872af86498894fd18/test/e2e/installplan_e2e_test.go#L3211, this test always fails.