model: validate unique bundle versions

operator-framework / operator-registry

Operator Registry runs in a Kubernetes or OpenShift cluster to provide operator catalog data to Operator Lifecycle Manager.

Apache License 2.0

212 stars 248 forks source link

model: validate unique bundle versions #1417

Closed joelanford closed 3 months ago

joelanford commented 3 months ago

Description of the change: Validate that bundles within a package use unique semver versions.

Motivation for the change: This has always been assumed. Now we are explicitly checking.

I verified that the operatorhubio catalog and all of Red Hat's catalogs for OCP 4.15 and 4.16 continue to pass with this new validation.

Are there any other catalogs that should be checked?

Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /docs
[ ] Commit messages sensible and descriptive

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operator-framework/operator-registry/blob/master/OWNERS)~~ [joelanford] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.22%. Comparing base (e787595) to head (0f175eb). Report is 3 commits behind head on master.

Files	Patch %	Lines
pkg/api/api_to_model.go	50.00%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1417 +/- ## ========================================== + Coverage 48.14% 48.22% +0.07% ========================================== Files 136 136 Lines 12780 12805 +25 ========================================== + Hits 6153 6175 +22 - Misses 5593 5595 +2 - Partials 1034 1035 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grokspawn commented 3 months ago

/lgtm