Closed joelanford closed 2 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.53%. Comparing base (
1f9e725
) to head (6a917e9
). Report is 15 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: joelanford, perdasilva
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Description of the change:
This PR adds explicit handling for SIGINT and SIGTERM, so that we can catch those signals and propagate them via a Go context to long running processes in order to perform a graceful shutdown.
Motivation for the change:
Temporary files are being left behind because
defer
statements are not executed when these signals are not caught and handled by the program. This PR ensures that we rundefer
statements prior to exiting.Reviewer Checklist
/docs