Closed camilamacedo86 closed 4 years ago
Is this reproducible with the helm
CLI? I'm fairly sure the helm-operator is correctly setting the upgrade.Force
option during the upgrade, so I would expect the helm
CLI to have this same issue.
If it does, we should close this issue and get clarification on this upstream in the Helm project.
@camilamacedo86 @dian-xh, looks like this has already been discussed upstream. Check out https://github.com/helm/helm/issues/7173.
I think we should close this since the helm-operator is working as expected (i.e. applying the force
option when the force annotation is set to true).
HI @dian-xh,
As described in the above comments I understand that all is working as expected. See that SDK lib will allow you to apply the flag, however, how the flags work is something that is part of the Helm implementation.
So, I am closing this one. However, please, feel free to ping us to re-open it or raise new issues if you see that it is required.
@camilamacedo86 thanks for the update. your test updated the replica, which is not an immutable field. this is not a good test for the
--force
option, since it will pass even withoutwith further tests today, it appears the
--force
behavior in the0.17.1
base image is backwards. I'd like to share the following steps to reproduce the issue:helm.operator-sdk/upgrade-force
annotation--force
:oc annotate elasticstack/logging "helm.operator-sdk/upgrade-force"="True"
--force
:oc annotate elasticstack/logging "helm.operator-sdk/upgrade-force"="False"
{"level":"info","ts":1591302627.458174,"logger":"helm.controller","msg":"Reconciled release","namespace":"ibm-common-services","name":"logging","apiVersion":"elasticstack.ibm.com/v1alpha1","kind":"ElasticStack","release":"logging"
the observed behaviour appears to be:
"helm.operator-sdk/upgrade-force"="True"
, the behavior is consistent with helm--force
option NOT applied"helm.operator-sdk/upgrade-force"="False"
, the behavior is consistent with helm--force
option appliedthis is the opposite from in the sdk doc: https://sdk.operatorframework.io/docs/helm/reference/advanced_features/#use-helm-upgrade---force-for-deployment
from : https://github.com/operator-framework/operator-sdk/issues/3144#issuecomment-639134918