operator-framework / operator-sdk

SDK for building Kubernetes applications. Provides high level APIs, useful abstractions, and project scaffolding.
https://sdk.operatorframework.io
Apache License 2.0
7.1k stars 1.73k forks source link

Correct the Docker buildx command in SDK 1.25.0 upgrade doc #6687

Open semihbkgr opened 4 months ago

semihbkgr commented 4 months ago

Description of the change:

The arg for the docker buildx build command was missing in the documentation, resulting in the following error:

ERROR: "docker buildx build" requires exactly 1 argument.

I have added the arg as the current directory: docker buildx build --push --platform=$(PLATFORMS) --tag ${IMG} -f Dockerfile.cross .

Motivation for the change:

I identified this subtle issue while upgrading an operator to version 1.25.0.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

openshift-bot commented 1 month ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 2 weeks ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale