search

operator-framework / operator-sdk

SDK for building Kubernetes applications. Provides high level APIs, useful abstractions, and project scaffolding.
https://sdk.operatorframework.io
Apache License 2.0
7.1k stars 1.73k forks source link

chore: fix function names #6709

Open depthlending opened 3 months ago

depthlending commented 3 months ago

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

depthlending commented 2 months ago

Anything need I to do?

grokspawn commented 2 months ago

It looks like you just need to rebase this PR. https://github.com/operator-framework/operator-sdk/pull/6691 updated the testdata already (which should've been done as part of the new tag/release, but wasn't).
So the failures should go away after that.

grokspawn commented 2 months ago

/override sanity/docs

openshift-ci[bot] commented 2 months ago

@grokspawn: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/operator-framework/operator-sdk/pull/6709#issuecomment-2082837574): >/override sanity/docs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
grokspawn commented 2 months ago

/override docs

openshift-ci[bot] commented 2 months ago

@grokspawn: Overrode contexts on behalf of grokspawn: docs

In response to [this](https://github.com/operator-framework/operator-sdk/pull/6709#issuecomment-2082838856): >/override docs Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
depthlending commented 3 weeks ago

friendly ping~

acornett21 commented 3 weeks ago

@depthlending Can you rebase, so we can make sure all tests pass? Thanks.