search

operatorai / modelstore

🏬 modelstore is a Python library that allows you to version, export, and save a machine learning model to your filesystem or a cloud storage provider.
Apache License 2.0
376 stars 25 forks source link

Regression: Model store created with Keras models breaks with the latest merge #144

Closed cdknorow closed 2 years ago

cdknorow commented 2 years ago

@nlathia it looks like the change made to merge the Keras and TensorFlow managers may have broken older model stores. This is the error I see when loading a model that was previously saved.


def get_manager(name: str, storage: CloudStorage = None) -> ModelManager:
       manager = _LIBRARIES[name](storage)
E       KeyError: 'keras'

This actually brings up a good regression test.

Create a model store that has one of each type of model, then the test can try and load all the models to validate they are still working after any changes.

nlathia commented 2 years ago

Thanks! This one is a fairly straightforward fix, leave it with me.

nlathia commented 2 years ago

Good idea for the regression test too, I had started thinking about this sort of thing in relation to the windows path bug as well:

nlathia commented 2 years ago

@cdknorow PR with a fix is open! Feedback welcome. I'm going to set up a suite of more generic regression tests in a separate PR.

nlathia commented 2 years ago

This one is merged now and it will go out in the next release!

nlathia commented 2 years ago

Closing now, this has been released with modelstore==0.0.74