operatorequals / covertutils

A framework for Backdoor development!
http://covertutils.readthedocs.io
436 stars 69 forks source link

pip install future #6

Closed cclauss closed 5 years ago

cclauss commented 7 years ago

Please review, squash, and accept this PR. We need future in place and we need Py2 tests passing.

operatorequals commented 7 years ago

This PR failes in Travis in the future package with the following traceback:

Traceback (most recent call last):

  File "/home/travis/build/operatorequals/covertutils/tests/test_Compressor.py", line 29, in test_feasibility

    plain = bytes( choice( random_bytes if i % 2 else ascii_letters ) for i in range( byte_len ) )

  File "/home/travis/virtualenv/python2.7.13/lib/python2.7/site-packages/future/types/newbytes.py", line 104, in __new__

    if len(args[0]) == 0:

TypeError: object of type 'generator' has no len()

Which seems like it belongs to the future code itself and not to the build. Is there a way to resolve that?

(I've been on vacation for the last week and I was AFK)

operatorequals commented 7 years ago

Also the future package must not be a requirement for the whole build, just for the tests. Do you plan anything different than that? Excuse me for asking but Python2/3 code is not my thing yet...

And the last commit also fails in the tests with a Traceback