opetchey / multifarious_response_diversity

MIT License
0 stars 0 forks source link

Mathematical quality #1

Closed opetchey closed 1 year ago

opetchey commented 1 year ago

I started some work on simulating the dependence of a rate on two environmental variables, when they act additively and non-additively. I've started by using the Eppley function (see the report for details). The additive version is fine. But while I have added an interaction, the maths is rather low quality. E.g. changing the interaction term changes multiple things, and not just one (e.g. the optimum). I might be able to make something nicer, but probably someone with more mathematical skills could do so more efficiently and probably produce something better. I thought to first ask Shyamolina if she could help. And after that a professor here, Reinhard Furrer. I've worked with him before and would be happy to again. If either of them help with this, then I think we must add them to the project team (meaning among other things they will be co-author).

Interested in your thoughts. (I think that all current team members should approve addition of any new team members.)

SamRPJRoss commented 1 year ago

Hi Owen, sounds sensible to me. The maths is beyond me, so if nobody currently in the project team can wrangle it at present, I definitely approve of bringing on Shyamolina or Reinhard Furrer to help speed things up.

pennekampster commented 1 year ago

Hi there, this paper uses an interactive model of temperature and nutrient concentration. It predicts that optimum temperature is a saturating function of increasing nutrient concentration and seems better behaved than the current model used for simulations: see figure 2 https://onlinelibrary.wiley.com/doi/full/10.1111/gcb.13641 That said, I am totally happy with additional team members to help with this issue!

opetchey commented 1 year ago

Thanks Frank.

I think we can make this non-essential. I'm relatively happy with a second and very simple implementation of the interaction. The GAM results still give the same detection of interaction or not.

I did make another issue (#3) about trying different performance functions and interactions terms in order to increase confidence that the response diversity measurement method will work for other cases. But that is not about quality of the maths used for the functions, so I will close this issue.