search

opf / helm-charts

OPF helm chart repository
https://charts.openproject.org
GNU General Public License v3.0
11 stars 20 forks source link

fix(secret_s3): add quote around port #102

Closed morganbasset closed 4 months ago

morganbasset commented 4 months ago

https://community.openproject.org/work_packages/53616/activity

This fix chart in version 5.1.2

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 83c55a51b3a971adaea4d60878b48891b1114b8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------ | ----- | | @openproject/helm-charts | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

machisuji commented 4 months ago

@morganbasset Thank you for the PR! Out of curiosity, what is the error that can be caused by not quoting this?

Either way I think the PR is fine, but you will need to adjust the spec too to make it green again! See https://github.com/opf/helm-charts/blob/main/spec/charts/openproject/s3_spec.rb#L26

morganbasset commented 4 months ago

@morganbasset Thank you for the PR! Out of curiosity, what is the error that can be caused by not quoting this?

Either way I think the PR is fine, but you will need to adjust the spec too to make it green again! See https://github.com/opf/helm-charts/blob/main/spec/charts/openproject/s3_spec.rb#L26

Hi, this is the error I get when the value in not quoted failed to create resource: Secret in version "v1" cannot be handled as a Secret: json: cannot unmarshal number into Go struct field Secret.stringData of type string: failed to create resource: Secret in version "v1" cannot be handled as a Secret: json: cannot unmarshal number into Go struct field Secret.stringData of type string

Thanks for merging the PR ;)