search

opf / helm-charts

OPF helm chart repository
https://charts.openproject.org
GNU General Public License v3.0
11 stars 23 forks source link

feat(openproject): Add extraVolumes and extraVolumeMounts option #118

Closed dominikkaminski closed 4 months ago

dominikkaminski commented 5 months ago

This PR adds templates for additional volumes and their mounts in deployments/jobs. This is useful, when f.e. the truststore should be changed:

extraVolumes:
  - name: "trusted-cert-secret-volume"
    secret:
      secretName: "my-certificates-ca-tls"
      items:
        - key: "ca.crt"
          path: "ca-certificates.crt"
extraVolumeMounts:
  - name: "trusted-cert-secret-volume"
    mountPath: "/etc/ssl/certs/ca-certificates.crt"
    subPath: "ca-certificates.crt"
changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: d0189252320ed0aa85d07dce40513ce720a8a58f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------ | ----- | | @openproject/helm-charts | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

oliverguenther commented 5 months ago

Hi @dominikkaminski, thanks for the contribution. Could you add a description on common use cases so we can add this to our documentation?

We'll take care of adding a test for this.

dominikkaminski commented 5 months ago

Hi @dominikkaminski, thanks for the contribution. Could you add a description on common use cases so we can add this to our documentation?

We'll take care of adding a test for this.

Hi @oliverguenther - I've added the description and use-case what I need it for: Using OpenProject in an environment with self-signed certificates.

oliverguenther commented 5 months ago

Thanks a lot @dominikkaminski 👍 I'll take care of the tests and release the change