search

opf / helm-charts

OPF helm chart repository
https://charts.openproject.org
GNU General Public License v3.0
12 stars 22 forks source link

Use existingSecret for oidc secret as well #63

Closed webnotesweb closed 9 months ago

webnotesweb commented 9 months ago

Hello,

I have noticed that you have done recently refactoring of secrets handling and improving secret management. Thank you for that! I am referring for example to these: https://github.com/opf/helm-charts/pull/46 https://github.com/opf/helm-charts/issues/17

So this current "issue" might not be considered issue/bug but rather security enhancement suggestion if I may.

If possible, can you please enable use of existingSecret as well for oidc secret just as you have done with PG for example.

Thank you very much for your time and help!

oliverguenther commented 9 months ago

Thanks for your report, indeed this is a good use case for OIDC as well, and I'll submit a PR when I find the time. We welcome outside contributions as well