search

opgm / openpilot

GM openpilot is an open source driver assistance system. openpilot performs the functions of Automated Lane Centering and Adaptive Cruise Control for over 100 supported car makes and models.
https://standbacklabs.com
MIT License
57 stars 37 forks source link

GM: Update CAMERA_ACC_CAR pedal interceptor pressed threshold #109

Closed garrettpall closed 2 months ago

garrettpall commented 3 months ago

515 from panda test is 10.88 when converted for OP with DBC. We need the OP threshold limit lower than panda so OP stops sending commands before panda blocks them. image

nworb-cire commented 2 months ago

If the threshold is set too low, the jostling of the car (e.g. going over a bump) can lead to a false tap which causes the car to brake abruptly for a moment before ACC recovers. This used to be set to 12 for ASCM cars and that was too low.

garrettpall commented 2 months ago

If the threshold is set too low, the jostling of the car (e.g. going over a bump) can lead to a false tap which causes the car to brake abruptly for a moment before ACC recovers. This used to be set to 12 for ASCM cars and that was too low.

Can we raise the panda threshold?