search

opgm / openpilot

GM openpilot is an open source driver assistance system. openpilot performs the functions of Automated Lane Centering and Adaptive Cruise Control for over 100 supported car makes and models.
MIT License
57 stars 39 forks source link

Reverse CC main switch logic when using Pedal Interceptor and update alerts #41

Closed JasonJShuler closed 3 weeks ago

JasonJShuler commented 2 years ago

~~Currently every time you press set/resume you must remember to press cancel or the vehicle cruise remains active.

Either find a way for OP to cancel CC (e.g. pedal sending bad voltages momentarily; maybe send single active AEB frame) Or reverse the logic so OP only works when CC system is disabled.~~

Logic is reversed, however the error message ('cc is disabled' when it is enabled) is confusing.

Show message on startup?

JasonJShuler commented 2 years ago

Probably going to reverse the logic. This only applies to vehicles without stock ACC anyway, so it sort of makes sense. Less tomfoolery, increased safety short term

JasonJShuler commented 2 years ago

Partially resolved with this commit: https://github.com/opgm/openpilot/commit/00ae209ddde58d41074044193c8f7d05ddfde440