Confirm validity and use ECMEngineStatus.Brake_Pressed instead of value threshold

opgm / openpilot

GM openpilot is an open source driver assistance system. openpilot performs the functions of Automated Lane Centering and Adaptive Cruise Control for over 100 supported car makes and models.

MIT License

57 stars 39 forks source link

Confirm validity and use ECMEngineStatus.Brake_Pressed instead of value threshold #43

Closed JasonJShuler closed 2 years ago

JasonJShuler commented 2 years ago

Per discussion in https://github.com/commaai/openpilot/pull/23617, it is requested to use a boolean-style signal. Need to make sure Brake_Pressed from this source is available across all cars, and that it closely matches existing brakepressed events in OP

JasonJShuler commented 2 years ago

Jason Young took care of the first-class review, thanks!