Fixed gap adjust to change personalities

opgm / openpilot

GM openpilot is an open source driver assistance system. openpilot performs the functions of Automated Lane Centering and Adaptive Cruise Control for over 100 supported car makes and models.

https://standbacklabs.com

MIT License

57 stars 37 forks source link

Fixed gap adjust to change personalities #96

Closed dimdom69 closed 9 months ago

dimdom69 commented 9 months ago

Fixed using the gap adjust button to cycle between driving personalities. There was a small logic error in the existing code. The Toggles menu will now also correctly update based on the selected personality, and cycling personalities will display a notification indicating the currently selected personality.

nworb-cire commented 9 months ago

Sorry, I rebased off master before getting a chance to review this. Are you able to rebase off of dev to make a clean merge?

dimdom69 commented 9 months ago

I believe it should be ready to go now.

nworb-cire commented 9 months ago

This looks good, thanks! I'll merge what you have now, but it would be nice if we could condense into just a single event and generate the notification text dynamically from params.