search

ophio / secure-preferences

Android secure shared preferences using Android Keystore system
https://medium.com/@vashisthg/android-secure-shared-preferences-10f8356a4c2b
Apache License 2.0
348 stars 56 forks source link

Any further plans for improvement? #5

Closed Rainer-Lang closed 7 years ago

Rainer-Lang commented 9 years ago

Maybe RxJava... https://github.com/pwittchen/prefser

vashisthg commented 9 years ago

Thanks for the suggestion. Wait for next iteration.

Rainer-Lang commented 9 years ago

OK thanks for the fast answer. When do you want to release .02?

vashisthg commented 9 years ago

Let us discuss first about the usage of RxJava in our library and whether its an overkill for this project or not. @Rainer-Lang What are your suggestions for where RxJava could be useful here.

cc @ragdroid

vashisthg commented 9 years ago

As https://github.com/pwittchen/prefser wraps SharedPreferences, it could be used along with our library, So I don't think we need to reinvent the wheel. @vickyturtle @ragdroid What are your thoughts?

ragdroid commented 9 years ago

@vashisthg Yes I agree. Also I am not sure where RxJava can be applied. Maybe @vickyturtle can give us a better idea regarding this.

vickyturtle commented 9 years ago

@vashisthg I don't think implementing RxJava in here makes much sense, but may be we can try to make secure-preferences injectable in https://github.com/pwittchen/prefser in place of normal SharedPreferences.