search

ophirhan / cnsr-vlc-viewer-addon

GNU General Public License v3.0
14 stars 18 forks source link

fixed the problem when you could change the volume while muted #119

Closed alonShevach closed 3 years ago

alonShevach commented 3 years ago

please note that i removed(commented out) the while loop on line 173, that while loop wasnt really looping, it was running once and then stopped. changed it to a if condition, which will loop because we are inside an infinite loop.

i think ophir or eyal really needs to see this one for approval.

ophirhan commented 3 years ago

If want to prevent the user from being able to change the volume while muted (should we that's a discussion for the issue section)? We need to set the volume to 0 in the update function of mute.

The purpose of the loop in line 173 is to keep handling tags until we reach a tag which hasn't started yet, only then we go to sleep. the loop iterates when there are collisions between tags or when we execute a skip tag and land on another tag.

Either way the change to the loop should have been raised as a separate issue and discussed :-)

alonShevach commented 3 years ago

That is the main reason i wanted you or eyal to review this, i am not sure the loop is doing its purpose, i will check, and if it isn't i will make this an issue.