opinkerfi / adagios

Adagios - Web Based Nagios Configuration
GNU Affero General Public License v3.0
330 stars 75 forks source link

Settings -> Edit nagios.cfg does not handle multivalues at all #118

Closed tomas-edwardsson closed 10 years ago

tomas-edwardsson commented 11 years ago

I was looking for a way to add something like broker_modules and that just isn't possible. We need a add option there for more options.

palli commented 11 years ago

Edit nagios.cfg could look something like the pnp configuration does: http://adagios.opensource.is/misc/pnp4nagios

Special tab for broker modules and cfg_file / cfg_directory values would be a good idea.

On Thu, May 9, 2013 at 5:24 PM, Tomas Edwardsson notifications@github.comwrote:

I was looking for a way to add something like broker_modules and that just isn't possible. We need a add option there for more options.

— Reply to this email directly or view it on GitHubhttps://github.com/opinkerfi/adagios/issues/118 .

tomas-edwardsson commented 11 years ago

I went down the road trying to classify the variables into groups, they are just so damn many. I think I actually threw away the spreadsheet with what goes where.

palli commented 11 years ago

We can start easy:

General; Config files; Broker Modules

cfg_* attributes and broker_module attributes need special attention anyway so we need special widgets for them.

The rest "organize everything into a group" can come later.

tomas-edwardsson commented 11 years ago

So what we are talking about would be,

General - commonly used options Configuration Files - yes those Broker Modules - them Other - Everything else

tomas-edwardsson commented 11 years ago

Another thing I remembered is our friend, pynag/Model/all_attributes.py. It does not have a classification of what takes multivariables and what doesn't. I'm going into a little trip down source code lane to see if I can extract information from the Nagios sources.

gradecke commented 11 years ago

maybe as an inspiration for the grouping process:

the guys at lilac-reloaded ( http://sourceforge.net/projects/lilac--reloaded/) have several smaller groups, based on setting areas:

Paths
Status
Security
Restart Actions
Logging
External Commands
Retention
Global
Intervals
Flap
Timeouts
Obsess
Freshness
Broker
Debug
Other

The advantage here is that scrolling is kept to a minimum and one doesn't actually need to use ctrl+f to find a setting. that's also the downside though, unless you know/understand where each setting is, you might have to click a lot.

palli commented 10 years ago

I don't foresee anyone fixing this anytime soon, and since the use case is relatively higher on other aspects of adagios i'm closing this for now.

If there is actual need for the feature, i am sure someone will step up with a pull request, or at least reopen the issue.