opinkerfi / adagios

Adagios - Web Based Nagios Configuration
GNU Affero General Public License v3.0
330 stars 75 forks source link

Service on hostgroup: Saving service sets hostgroup_name to Null #389

Closed nzurku closed 10 years ago

nzurku commented 10 years ago

Perhaps I am going about adding a service to a hostgroup wrong, but I'm having issues with what appears to be a GUI/config generation issue.

Editing my service on a page labeled "service System Status on host null" gives me no entry for the hostgroups, but also when I save the page, the hostgroup_name gets set to "null". To fix this, I have to use the geek edit once I'm done and correctly change the hostgroup_name from null to "HVAC" in my case.

Am I doing the hostgroup service wrong, or is the Adagios GUI for service creation wiping out the hostgroup_name field since there is no text box for such an entry?

palli commented 10 years ago

This sounds like a bug. Can you give me the following so we can troubleshoot further:

nzurku commented 10 years ago

Adagios Version: Adagios version: 1.5.0-1.git.155.c25a457.el6. Latest: 1.5.0 Pynag Version: 0.8.9

Steps: Create a service with a hostgroup and a hostname of "null", continue editing service after... Once complete - and you save the service - you'll notice that the warning that "the service applies to an entire hostgroup" has disappeared. Hit Geek Edit, and you'll see that hostgroup_name is also null.

To fix it, using Geek Edit, it is possible to correct the hostgroup_name, but if you ever again save using the Adagios service GUI, the warning goes away and the service's hostgroup_name is back to null.

Before bug: define service { use generic-service check_command check-liebert-ac-temp!google123!returnTemp!"105,45"!"100,50" hostgroup_name HVAC passive_checks_enabled 0 service_description Return Temperature host_name null check_interval 1 contact_groups Facilities Admin }

After bug:

define service { use generic-service check_command check-liebert-ac-temp!google123!returnTemp!"105,45"!"100,50" hostgroup_name null passive_checks_enabled 0 service_description Return Temperature host_name null check_interval 1 contact_groups Facilities Admin }

ghost commented 10 years ago

Also experiencing this issue plus a related problem..

If I attempt to create a service attached to a host_group, host_groups gets reset to null and also cannot assign a "Check Command" to the service. If I choose the required command and save, it does not save and still displays "Please select a check command" if re edited. If I attach service to a "host" instead of "host_group" I am able to set a check command and save successfully.

dnewsholme commented 10 years ago

I can confirm this bug too. The form doesn't have a hostgroup option on the service config page which is why i assume it removes the record.

palli commented 10 years ago

I don't know exactly when this bug was introduced, but the fact the hostgroup field is missing from the form is definitely one part of the problem.

We are using html multi choice fields, and part of the problem is that server side we cannot distinguish between the user removing all hostgroups (thus changing to null) and the field not being present at all.

I am moving to a different implementation, where markup wise the fields are regular input boxes with select2 'tagging' support to make it look like the multichoice field we have now.

This is a major change, and i am currently writing a lot of unit tests for the objectbrowser form, to minimize this breaking other things.

ghost commented 10 years ago

Just wondering if there is any progress with this one?

I would like to use hostgroups to help with grouping services per similar devices. Would love to get using Adagios for this.

A.

dnewsholme commented 10 years ago

You can do this via geek edit. Its just the web form is missing this setting.

Sent from my Google Nexus 4 On 16 Sep 2014 19:36, "paradoxni" notifications@github.com wrote:

Just wonder if there is any progress with this one?

I would like to use hostgroups to help with grouping services per similar devices. Would love to get using Adagios for this.

A.

— Reply to this email directly or view it on GitHub https://github.com/opinkerfi/adagios/issues/389#issuecomment-55791633.

palli commented 10 years ago

Sorry for the late reply!

This was fixed a while back in pull request 393 has a new implementation behind the scenes that fixes this an many related bugs.

Its already been merged so the problem should be gone if you are using latest testing.

Im marking the bug as closed, don't hesitate to reopen if the problem persists.