Update check_apcext.pl - Githubissues

opinkerfi / nagios-plugins

Small army of nagios-plugins either made or maintained by opinkerfi

58 stars 43 forks source link

Update check_apcext.pl #14

Closed lockland closed 9 years ago

lockland commented 9 years ago

Fix snmp session get without community defined

palli commented 9 years ago

Hello,

Was it intentional that you closed the pull request ?

Thanks for also cleaning up the intentation of the file, however can you seperate that from the actual fix so we can review separately ?

I suggest:

1 Commit with title 'Fix code indentation'
1 Commit with title 'Fix snmp session get without community defined'

The latter should not contain anything but the fix mentioned.

Since this patch is small, it is ok if you combine them in one pull request.

palli commented 9 years ago

To clarify the reasoning here: Indentation changes changes a lot of lines, and it is easier for us to review if there are no changes to code logic in the same commit.

lockland commented 9 years ago

I closed the pull request because it's was bad format. I create a new pull request with other fixes

Sorry my bad english