search

opinkerfi / nagios-plugins

Small army of nagios-plugins either made or maintained by opinkerfi
58 stars 43 forks source link

Refactor check package updates #8

Closed palli closed 11 years ago

palli commented 11 years ago

One bug fix and minor refactors.

palli commented 11 years ago

@tomas-edwardsson much appreciated if you can review.

tomas-edwardsson commented 11 years ago

The only thing I worry about is the update types, before this patch it would add types if check_package_updates did not recognize them. But always return performance data for the 4 types hard coded even if there were no updates available.

I have tested this on ubuntu, fedora and rhel and only seen these 4 categories. But this should function on opensuse and a few others as well, see http://www.packagekit.org/pk-users.html

palli commented 11 years ago

That does not change.

Just test it by setting known_types=[] and running the plugin.

tomas-edwardsson commented 11 years ago

I trust you.. :+1:

Tested and works on: Fedora 18 Ubuntu 10.04

Merging.