search

opiproject / ansible-opi-dpu

Ansible Modules for DPUs
Apache License 2.0
6 stars 8 forks source link

feat(bmc_fw_update): compare version with filename #35

Closed glimchb closed 8 months ago

glimchb commented 8 months ago

This is instead of comparing before and after version

Fixes #22

before the fix:

2024-02-27 00:19:40 TASK [bmc_fw_update : Print BMC Version] ***************************************
2024-02-27 00:19:40 task path: /home/boris/ansible-opi-dpu/roles/bmc_fw_update/tasks/main.yml:81
2024-02-27 00:19:40 ok: [10.10.10.1] => {
2024-02-27 00:19:40     "msg": [
2024-02-27 00:19:40         "BF-23.10-5"
2024-02-27 00:19:40     ]
2024-02-27 00:19:40 }
2024-02-27 00:19:40
2024-02-27 00:19:40 TASK [bmc_fw_update : Validate fw image changed from before] *******************
2024-02-27 00:19:40 task path: /home/boris/ansible-opi-dpu/roles/bmc_fw_update/tasks/main.yml:85
2024-02-27 00:19:40 fatal: [10.10.10.1]: FAILED! => {
2024-02-27 00:19:40     "msg": "The conditional check 'get_bmc_facts_before.redfish_facts.firmware.entries[0].Version != get_bmc_facts_after.redfish_facts.firmware.entries[0].Version' failed. The error was: error while evaluating conditional (get_bmc_facts_before.redfish_facts.firmware.entries[0].Version != get_bmc_facts_after.redfish_facts.firmware.entries[0].Version): 'dict object' has no attribute 'redfish_facts'. 'dict object' has no attribute 'redfish_facts'"
2024-02-27 00:19:40 }
2024-02-27 00:19:40

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com