opiproject / ansible-opi-dpu

Ansible Modules for DPUs
Apache License 2.0
6 stars 8 forks source link

[fw update]: make it generic enough to allow Nvidia CEC update with just an argument #51

Closed glimchb closed 5 months ago

glimchb commented 5 months ago

i also tested {{ hostvars[inventory_hostname]['get_bmc_facts_bluefield_fw_erot'] }} that works, but for some reason {{ ansible_facts }} is empty !?

replacing get_bmc_facts_bmc_firmware with get_bmc_facts_bluefield_fw_erot works now:

diff --git a/roles/bmc_fw_update/defaults/main.yml b/roles/bmc_fw_update/defaults/main.yml
index 9ff763c..ac5a589 100644
--- a/roles/bmc_fw_update/defaults/main.yml
+++ b/roles/bmc_fw_update/defaults/main.yml
@@ -6,5 +6,5 @@

 bmc_fw_update_reboot: true
 bmc_fw_update_job_wait: true
-bmc_fw_update_image_url: https://content.mellanox.com/BlueField/BMC/23.10-1-oct-2023/bf3-bmc-23.10-5_opn.fwpkg
-bmc_fw_update_image_file: /tmp/bf3-bmc-23.10-5_opn.fwpkg
+bmc_fw_update_image_url: https://content.mellanox.com/BlueField/BMC/23.10-1-oct-2023/cec1736-ecfw-00.02.0152.0000-n02-rel-prod.fwpkg
+bmc_fw_update_image_file: /tmp/cec1736-ecfw-00.02.0152.0000-n02-rel-prod.fwpkg
diff --git a/roles/bmc_fw_update/tasks/main.yml b/roles/bmc_fw_update/tasks/main.yml
index 037e47d..9e525b0 100644
--- a/roles/bmc_fw_update/tasks/main.yml
+++ b/roles/bmc_fw_update/tasks/main.yml
@@ -11,7 +11,7 @@

 - name: Print BMC Version
   ansible.builtin.debug:
-    msg: "{{ get_bmc_facts_bmc_firmware }}"
+    msg: "{{ get_bmc_facts_bluefield_fw_erot }}"

 - name: Check if firmware image exists locally {{ bmc_fw_update_image_file }}
   ansible.builtin.stat:
@@ -83,9 +83,9 @@

 - name: Print BMC Version
   ansible.builtin.debug:
-    msg: "{{ get_bmc_facts_bmc_firmware }}"
+    msg: "{{ get_bmc_facts_bluefield_fw_erot }}"

 - name: Validate fw image matches given filename
   ansible.builtin.fail:
     msg: "{{ bmc_fw_update_version_failure }}"
-  when: not bmc_fw_update_image_file is search(get_bmc_facts_bmc_firmware | regex_search('[0-9-.]+'))
+  when: not bmc_fw_update_image_file is search(get_bmc_facts_bluefield_fw_erot | regex_search('[0-9-.]+'))
(END)
glimchb commented 5 months ago

with #59 the change is tiny only via arguments

diff --git a/roles/bmc_fw_update/defaults/main.yml b/roles/bmc_fw_update/defaults/main.yml
index 8de1cd2..601111d 100644
--- a/roles/bmc_fw_update/defaults/main.yml
+++ b/roles/bmc_fw_update/defaults/main.yml
@@ -6,6 +6,6 @@

 bmc_fw_update_reboot: true
 bmc_fw_update_job_wait: true
-bmc_fw_update_inventory_name: bmc_firmware
-bmc_fw_update_image_file: /tmp/bf3-bmc-24.01-5_opn.fwpkg
+bmc_fw_update_inventory_name: bluefield_fw_erot
+bmc_fw_update_image_file: /tmp/cec1736-ecfw-00.02.0152.0000-n02-rel-prod.fwpkg
 bmc_fw_update_image_url: https://content.mellanox.com/BlueField/BMC/24.01-5-Jan-2024/{{ bmc_fw_update_image_file | basename }}