search

opiproject / ansible-opi-dpu

Ansible Modules for DPUs
Apache License 2.0
6 stars 8 forks source link

feat(get_bmc_facts): support both user/pass/auth #62

Closed glimchb closed 8 months ago

glimchb commented 8 months ago

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

sandersms commented 8 months ago

Should CodeQL be included in the automated testing for this repository?

Can the README markdown-lint error be corrected to resolve the required failing test?

glimchb commented 8 months ago

Should CodeQL be included in the automated testing for this repository?

I see Did not detect any languages to analyze. Please update input in workflow or check that GitHub detects the correct languages in your repository.   need to research how to fix it...

Can the README markdown-lint error be corrected to resolve the required failing test?

this readme was auto-generated... need to think what is the best approach here... next time we auto-generate it will return again... maybe ignore this specific file... don't know...

glimchb commented 8 months ago

This looks good, But we can add a common way of creating session and invoke that here instead of using basic auth to be consistent.. May be a future changes.

yep, added new role already https://github.com/opiproject/ansible-opi-dpu/blob/main/roles/bmc_session/tasks/main.yml