search

opiproject / opi-api

Open Programmable Infrastructure API and Behavioral Model
Apache License 2.0
31 stars 40 forks source link

feat: resource name IDENTIFIER enforcement #348

Closed glimchb closed 11 months ago

glimchb commented 1 year ago

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

glimchb commented 1 year ago

new linter PR to enforce IDENTIFIER is merged https://github.com/googleapis/api-linter/pull/1241 waiting on the new release https://github.com/googleapis/api-linter/releases comes from https://github.com/googleapis/api-linter/pull/1243

mardim91 commented 1 year ago

The changes to the EVPN GW API looks good to me. You have the green light from my side to merge this when this is needed.

glimchb commented 12 months ago

now waiting on https://github.com/docker-multiarch/google-api-linter/tags

glimchb commented 12 months ago

now waiting on https://github.com/docker-multiarch/google-api-linter/tags

released!

now fails on

docker run --user=$(id -u):$(id -g) --rm -v "/home/glimcb/opiproject/opi-api/storage":/defs -v "/home/glimcb/opiproject/opi-api/storage/../common/v1":/common namely/protoc-all:1.51_2 -i /common --lint -d v1alpha1 -l go -o ./v1alpha1/gen/go/  --go-source-relative
frontend_virtio_scsi.proto:170:39: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior".
frontend_virtio_scsi.proto:190:39: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior".
frontend_virtio_scsi.proto:216:39: Enum type "google.api.FieldBehavior" has no value named "IDENTIFIER" for option "google.api.field_behavior".

but we do have https://github.com/googleapis/googleapis/commit/f5987af9df625b86e23aed7218ab5f48e85e4ec8

so probably need new release of https://hub.docker.com/r/namely/protoc-all/tags

waiting on https://github.com/namely/docker-protoc/issues/382

glimchb commented 11 months ago

merged #387 instead