search

opiproject / opi-api

Open Programmable Infrastructure API and Behavioral Model
Apache License 2.0
32 stars 40 forks source link

refactor(storage): frontend cleanup pci leftovers #383

Closed artek-koltun closed 12 months ago

artek-koltun commented 1 year ago

FrontendNvmeService serves pcie and fabrics devices. Remove pci from names and comments.

got https://linter.aip.dev/216/nesting lint error and had to move state enum into namespace status message

glimchb commented 12 months ago

is https://linter.aip.dev/216/nesting new ? how come we were not failing it before ?

artek-koltun commented 12 months ago

is https://linter.aip.dev/216/nesting new ? how come we were not failing it before ?

The name of the field changed to state and triggered the check. This check was run against only State state = 1 However, I decided to move OperState enum for consistency as well since it is used only in that structure