search

opiproject / opi-evpn-bridge

OPI gRPC to EVPN GW FRR bridge
Apache License 2.0
14 stars 13 forks source link

feat(evpn-bridge): intel e2000 vendor plugin #386

Closed atulpatel261194 closed 2 weeks ago

mardim91 commented 5 months ago

I wonder is this is better to implement vendor plugin in their own repos and then import them here and use. we can't really maintain/code review that many plugins...

Hello @glimchb,

This is something that is our intention too. So we plan to do this in the future. We thought that is basic easier for now that we are implementing the whole rearchitecture thing and we test everything to put everything in one repo. When the main work is done then we can create different repos for the vendor plugins and inject them from there but for now let's keep everyhting in one place because that helps on the testing and doesn't introduce any extra integration effort.

I can open an issue to track this if you want

mardim91 commented 4 months ago

Hello @glimchb

I have noticed that you have putted an "invalid" tag on this PR. What does that exactly mean? can you please explain ?

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.31%. Comparing base (5440fb9) to head (17a048a). Report is 48 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (5440fb9) and HEAD (17a048a). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (5440fb9) | HEAD (17a048a) | |------|------|------| ||2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #386 +/- ## ========================================== - Coverage 50.77% 44.31% -6.46% ========================================== Files 37 25 -12 Lines 2525 1663 -862 ========================================== - Hits 1282 737 -545 + Misses 1114 838 -276 + Partials 129 88 -41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

atulpatel261194 commented 2 weeks ago

has been moved to opi-intel-bridge