search

opiproject / opi-gateway-evpn-cni

OPI Gateway for EVPN to CNI integration
Apache License 2.0
1 stars 2 forks source link

feat: initial implementation of evpn gw cni #14

Closed mardim91 closed 3 months ago

mardim91 commented 6 months ago

Initial implementation of EVPN GW CNI. Currently only Intel Mt.Evans IPUs are supported by this CNI. Target is to support more IPUs/DPUs in the future. It has an integration with the EVPN GW API .

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 1103 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (7020632) to head (12625ed).

:exclamation: Current head 12625ed differs from pull request most recent head 5c47616. Consider uploading reports for the commit 5c47616 to get more accurate results

Files Patch % Lines
pkg/utils/utils.go 0.00% 277 Missing :warning:
cmd/main.go 0.00% 204 Missing :warning:
pkg/sriov/sriov.go 0.00% 153 Missing :warning:
pkg/utils/packet.go 0.00% 153 Missing :warning:
pkg/config/config.go 0.00% 130 Missing :warning:
pkg/xpu/xpu.go 0.00% 113 Missing :warning:
pkg/utils/pci_allocator.go 0.00% 45 Missing :warning:
pkg/utils/netlink_manager.go 0.00% 22 Missing :warning:
pkg/types/types.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14 +/- ## ====================================== Coverage 0 0.00% ====================================== Files 0 9 +9 Lines 0 1104 +1104 ====================================== - Misses 0 1104 +1104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mardim91 commented 6 months ago

@glimchb Thank you for the review.

I will take a look

sandersms commented 5 months ago

@mardim91 Any update on the resolution of the comments?

mardim91 commented 5 months ago

@mardim91 Any update on the resolution of the comments?

Hello @sandersms,

No I haven't found the time to work on that yet. I will do it beginning of Q2. I was working on this PR: https://github.com/opiproject/opi-evpn-bridge/pull/377 please take a look when you find some time.

mardim91 commented 4 months ago

Hello @sandersms I have resolved all the above comments.

mardim91 commented 3 months ago

I have converted this to draft as the dependent PR in opi-evpn-bridge is still unmerged

https://github.com/opiproject/opi-evpn-bridge/pull/380

mardim91 commented 3 months ago

I have converted this to draft as the dependent PR in opi-evpn-bridge is still unmerged

opiproject/opi-evpn-bridge#380

The dependent PRs 0, 1 has been merged so this PR is ready

mardim91 commented 3 months ago

Hello @glimchb,

I have resolved all the comments that you have left. I will propose that maybe we can merge this one as the first PR to the project and then if we need to fix or add anything more we can create new PRs on top.

This PR is a working one and is quite some time open so I am thinking that we can merge it as the comments are resolved and all the dependent PRs in the OPI-EVPN-BR project are merged.

sandersms commented 3 months ago
  • code dup
  • ci failed
  • no tests
  • no godpu usage
  • readme removed badges
  • readme : i want to contribute section must stay

code dup fixed ci checks completed godpu inclusion resolved readme updated to include badges and contribution section

Tests for the feature are missing and should be included for validation. Issue https://github.com/opiproject/opi-gateway-evpn-cni/issues/16 opened to cover the missing aspect that needs to be added.