Closed mardim91 closed 3 months ago
Attention: Patch coverage is 0%
with 1103 lines
in your changes are missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
7020632
) to head (12625ed
).:exclamation: Current head 12625ed differs from pull request most recent head 5c47616. Consider uploading reports for the commit 5c47616 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@glimchb Thank you for the review.
I will take a look
@mardim91 Any update on the resolution of the comments?
@mardim91 Any update on the resolution of the comments?
Hello @sandersms,
No I haven't found the time to work on that yet. I will do it beginning of Q2. I was working on this PR: https://github.com/opiproject/opi-evpn-bridge/pull/377 please take a look when you find some time.
Hello @sandersms I have resolved all the above comments.
I have converted this to draft as the dependent PR in opi-evpn-bridge is still unmerged
I have converted this to draft as the dependent PR in opi-evpn-bridge is still unmerged
Hello @glimchb,
I have resolved all the comments that you have left. I will propose that maybe we can merge this one as the first PR to the project and then if we need to fix or add anything more we can create new PRs on top.
This PR is a working one and is quite some time open so I am thinking that we can merge it as the comments are resolved and all the dependent PRs in the OPI-EVPN-BR project are merged.
- code dup
- ci failed
- no tests
- no godpu usage
- readme removed badges
- readme : i want to contribute section must stay
code dup fixed ci checks completed godpu inclusion resolved readme updated to include badges and contribution section
Tests for the feature are missing and should be included for validation. Issue https://github.com/opiproject/opi-gateway-evpn-cni/issues/16 opened to cover the missing aspect that needs to be added.
Initial implementation of EVPN GW CNI. Currently only Intel Mt.Evans IPUs are supported by this CNI. Target is to support more IPUs/DPUs in the future. It has an integration with the EVPN GW API .