opiproject / sztp

Secure Zero Touch Provisioning (sZTP) in OPI
Apache License 2.0
20 stars 14 forks source link

use `ParseAuthorizedKey` instead of string parsing of the public key #411

Closed Xeckt closed 4 months ago

Xeckt commented 4 months ago

Few changes in this pull request, more than anticipated:

I hope all these changes are okay. Let me know if you would like to change anything or revert any of the changes. All tests have passed locally, including daemon tests.

Xeckt commented 4 months ago

Sorry for the title changes I borked up some stuff :D

On second consideration, it might be better to keep the struct field I changed to type as Algorithm

Xeckt commented 4 months ago

Thanks for the feedback! Will make the changes later today!

Xeckt commented 4 months ago

All changes and feedback resolved. Let me know if the new changes are ok!

Xeckt commented 4 months ago

Linter issues fixed, ran golangci-lint locally, seems all good.

Xeckt commented 4 months ago

Commits squashed!

glimchb commented 4 months ago

@Xeckt please note https://commitlint.js.org/ failing

Xeckt commented 4 months ago

Gah! Sorry!

glimchb commented 4 months ago

Gah! Sorry!

no worries. just add fix: or feat: in the start of the commit message and keep it lowercase...

Xeckt commented 4 months ago

Should be done now