search

opiproject / sztp

Secure Zero Touch Provisioning (sZTP) in OPI
Apache License 2.0
20 stars 14 forks source link

v0.2.0 release is missing https://pkg.go.dev/github.com/opiproject/sztp/sztp-agent@v0.2.0 #417

Open glimchb opened 4 months ago

glimchb commented 4 months ago

see https://pkg.go.dev/github.com/opiproject/sztp/sztp-agent?tab=versions

see https://pkg.go.dev/github.com/opiproject/sztp/sztp-agent@v0.0.0-20240624230406-856a04e51e02/pkg/secureagent

but I did create https://github.com/opiproject/sztp/releases/tag/v0.2.0

maybe related to #416 ?

glimchb commented 4 months ago

@Xeckt @bhoopesh369 can any of you look into this ?

Xeckt commented 4 months ago

Sure, I can take a look, had similar issues myself before.

Xeckt commented 4 months ago

Looks like it only detects the versioning for the sztp project instead of sztp-agent, and complains about it missing the package:

~/Documents/GitHub/sztp git:[cli-fixes]
go install github.com/opiproject/sztp/sztp-agent@v0.2.0
go: downloading github.com/opiproject/sztp v0.2.0
go: github.com/opiproject/sztp/sztp-agent@v0.2.0: module github.com/opiproject/sztp@v0.2.0 found, but does not contain package github.com/opiproject/sztp/sztp-agent

Which makes sense considering you removed it. Everything will have to be through opiproject/sztp instead which won't work so long as there is no go.mod in the root of the project. Not sure how this should update as you can't version a folder in github...

bhoopesh369 commented 4 months ago

I think tagging the packages inside will do it? since I guess only the folder was tagged

glimchb commented 4 months ago

maybe move everything up 1 level #416 git mv sztp-agent/* . ?

bhoopesh369 commented 4 months ago

https://stackoverflow.com/questions/62539376/can-you-tag-individual-folders-files-in-git

bhoopesh369 commented 4 months ago

maybe move everything up 1 level #416 git mv sztp-agent/* . ?

Would be the ideal solution

Xeckt commented 4 months ago

I think tagging the packages inside will do it? since I guess only the folder was tagged

What I was thinking.

glimchb commented 4 months ago

maybe move everything up 1 level #416 git mv sztp-agent/* . ?

Would be the ideal solution

let's do it. I'm supportive

Xeckt commented 4 months ago

We're happy to do this, in this case everything pretty much being located in the root of the project?

glimchb commented 4 months ago

I was waiting for #427 to go in , to avoid merge conflicts, after we can restructure folders