search

opis / closure

Serialize closures (anonymous functions)
https://opis.io/closure
MIT License
2.5k stars 84 forks source link

Fix PSR-4 class names #139

Closed williamdes closed 1 year ago

williamdes commented 1 year ago

Found in Debian: https://bugs.debian.org/1039811

GrahamCampbell commented 1 year ago

Thanks, though this change doesn't matter since these are just tests.

GrahamCampbell commented 1 year ago

The fact that debian are choosing to use their own phpunit instead of using the one the project says it supports (and installs, for itself!) is the issue here.

williamdes commented 1 year ago

Please re open this PR and consider reading the actual change this is non sense replying... Deceiving @GrahamCampbell

GrahamCampbell commented 1 year ago

Like I said, the bug is in Debian. Our test suite cannot be run on phpunit 10. We control how our tests are run, in our own composer.json. Using a global copy of phpunit is a huge mistake.

williamdes commented 1 year ago

And THIS HAS NOTHING TO DO WITH Debian. Use normal phpunit and it gives thee same results

williamdes commented 1 year ago

Like I said, the bug is in Debian. Our test suite cannot be run on phpunit 10. We control how our tests are run, in our own composer.json. Using a global copy of phpunit is a huge mistake.

This is false. It runs perfectly on phpunit 10, just two psr-4 warnings

williamdes commented 1 year ago

Even composer will be unhappy with non psr-4 compliant classes. This is so much obvious that my change has nothing to do with Debian or phpunit. It's basic psr-4 compliance..