search

opista / svn-blamer

📝 SVN Blamer - A VS Code extension to visually SVN-blame your code
https://marketplace.visualstudio.com/items?itemName=beaugust.blamer-vs
MIT License
18 stars 11 forks source link

StatusBarItem not updated on error #24

Closed 238855 closed 7 months ago

238855 commented 5 years ago

Some scenarios when annotation fails with no error:

Expected: Blamer StatusBar should show error state when failing to apply annotation. Actual: 'Blamer Started' text shown.

SVN Extension Info

Name: SVN
Id: johnstoncode.svn-scm
Description: Integrated Subversion source control
Version: 1.50.0
Publisher: Chris Johnston
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=johnstoncode.svn-scm
metacurb commented 5 years ago

Can you supply some more information regarding which SVN extension you're talking about? I'll need valid scenario recreation to produce the errors. Thank you

It also looks like the statusBar message for processing the revision is incorrect, which was added from your PR. Is there any reason why you did commit.revision + 1?

238855 commented 5 years ago

Sorry that was a mistake, I had previously been using forEach index to mark progress, hence +1 so we did not start counting from 0 i.e 0/75

On Thu, May 30, 2019 at 12:11 PM BeauAgst notifications@github.com wrote:

Can you supply some more information regarding which SVN extension you're talking about? I'll need valid scenario recreation to produce the errors. Thank you

It also looks like the statusBar message for processing the revision is incorrect, which was added from your PR. Is there any reason why you did commit.revision

  • 1?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BeauAgst/blamer-vs/issues/24?email_source=notifications&email_token=AADIBPJMAFMQXM23RNIYM2TPX6Y7PA5CNFSM4HQNQ5Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSB4YI#issuecomment-497294945, or mute the thread https://github.com/notifications/unsubscribe-auth/AADIBPP4ENQZZM43LUVLYALPX6Y7PANCNFSM4HQNQ5YQ .

-- -- Matt