search

opitzconsulting / jquery-mobile-angular-adapter

jquery mobile angular adapter
MIT License
517 stars 114 forks source link

[Popups] losing transition and position #170

Closed hsdk123 closed 11 years ago

hsdk123 commented 11 years ago

I'm noticing that the popups I've made through jQuery undergo the following changes when I add the adapter:

  1. Default position changes from [right next to the button pressed that triggers the popup] to [screen centre].
  2. I lose the transitions I've set on the popup (ex. data-transition="pop")

Here's a jsFiddle to illustrate:

http://jsfiddle.net/ZHKBA/133/

It would be nice if we could 1. keep the default position instead of moving popups to the centre of the screen, 2. get back transitions for more responsive UI.

Links: http://jquerymobile.com/demos/1.2.0-alpha.1/docs/pages/popup/ QuoteFromJqueryDoc: "By default, popups open centered vertically and horizontally over the thing you clicked (the origin) which is good for popups used as tooltips or menus"

tbosch commented 11 years ago

Hi, thanks for submitting this! This really is a bug. Will care for it soon.

Tobias

hsdk123 commented 11 years ago

Thanks for the fast reply, it's great to know that this is in active development!

hsdk123 commented 11 years ago

Is there perhaps a quick workaround to this? I'm currently trying to persuade some co-workers to switch over to Angular and use the adapter here for jqm and this is currently the only issue preventing me.

tbosch commented 11 years ago

Hi, this should be very easy to correct. However, I have been busy these days... Will look at it next week...

Tobias

hsdk123 commented 11 years ago

Thanks for the reply, hope things calm down for you over the next week.

tbosch commented 11 years ago

Hi, your jsfiddle is now working as expected...

Tobias

hsdk123 commented 11 years ago

Thanks for the fix, my team and I have now completely moved over to using Angular and the adapter!

tbosch commented 11 years ago

Your welcome!

Am 27.04.2013 um 02:44 schrieb "daegon123" notifications@github.com<mailto:notifications@github.com>:

Thanks for the fix, my team and I have now completely moved over to using Angular and the adapter!

— Reply to this email directly or view it on GitHubhttps://github.com/tigbro/jquery-mobile-angular-adapter/issues/170#issuecomment-17107332.