search

opitzconsulting / jquery-mobile-angular-adapter

jquery mobile angular adapter
MIT License
517 stars 114 forks source link

$waitDialog broken in 1.1.2 SNAPSHOT #69

Closed JohannesRudolph closed 11 years ago

JohannesRudolph commented 11 years ago

Calling $waitDialog is broken in 1.1.2 Snapshost. The following JSFiddle reproduces the issue:

http://jsfiddle.net/cmPAv/

JohannesRudolph commented 11 years ago

Looking further into it, it seems its not solely an issue with $waitDialog but with $.mobile.loading. it seems jqms loaderWidget.loader is not initialized at the time the angular module controller definition is executed. jqm would initialize it on the pagecontainercreate event as far as I see... Seems we need to hook the adapter somewhere later into the pipeline.

tbosch commented 11 years ago

Hi, thanks for reporting! This only applies when you show the waitDialog in the constructor of your controller. Using the wait dialog in a click event does work: http://plnkr.co/edit/f6Yh6f

Still, I will also look into this...

Tobias

JohannesRudolph commented 11 years ago

Hi Tobias, I noticed the same thing. I think it also only happens in controllers loaded on the first page. Probably jqm has not finished initializing by then or something...

On Fri, Nov 16, 2012 at 11:54 AM, Tobias Bosch notifications@github.comwrote:

Hi, thanks for reporting! This only applies when you show the waitDialog in the constructor of your controller. Using the wait dialog in a click event does work: http://plnkr.co/edit/f6Yh6f

Still, I will also look into this...

Tobias

— Reply to this email directly or view it on GitHubhttps://github.com/tigbro/jquery-mobile-angular-adapter/issues/69#issuecomment-10443485.

tbosch commented 11 years ago

Hi, your initial jsfiddle works now and correctly shows the waitDialog.

Thanks for reporting, Tobias