Open jperl opened 11 years ago
Yes, good idea. What do you think about the following:
feature('someFeature')
to enable itfeature({name: 'someComplexFeature', configProp1: 1, ...}
By this, we can still pass multiple features to one call of feature
.
Tobias
I like that a lot
What about instead: feature(name, [config]). Config would be an optional parameter so you could call
feature('someFeature')
feature('someFeature', { configProp1: 1, ... })
That way you do not need to pollute the config with a name property and you can call it the same way as now.
Yes, true.
However, right now, feature
accepts a list of features, e.g. feature('xhrSensor', 'timeoutSensor', ...)
. To keep this property, the object notation would be better...
Mmmh..
Tobais
Got it that makes a lot of sense. I agree with feature({name: 'someComplexFeature', configProp1: 1, ...}
Right now I have this line commented out because the application already uses angular.mock.e2e.$httpBackendDecorator and the mocks get overridden if I leave it there.
It would be a nice to be able to pass configuration options to features.