search

opl- / beatsaber-http-status

Live game status over web sockets.
MIT License
105 stars 36 forks source link

[Feature Request] Get custom colors #27

Closed Jared0430 closed 3 years ago

Jared0430 commented 5 years ago

It would be great if we could get the player chosen colors either in the status object, or better yet when the song starts with the colors for that level (taking into account the environment)

Bogo-Sort commented 4 years ago

I wanted to ask the same

LeoDJ commented 3 years ago

Yes, this would be greatly appreciated. I'm currently in the process of writing a Beatsaber lighting events to LED lighting bridge and not having custom colors really limits the functionality ^^'

Protected commented 3 years ago

Came here to ask for this, surprised it has such an old ticket. This would be very useful in the StatusObject.

codingcatgirl commented 3 years ago

Looking for this as well! Including the custom colors if they have been overridden by a map using Chromapper etc… https://bsmg.wiki/mapping/basic-lighting.html#map-color-overrides

opl- commented 3 years ago

Added in f093556fe50e4ec5d4470a2213033b2431f08a4c, released in v1.18.0. Also works with SongCore color overrides.

codingcatgirl commented 3 years ago

Holy shit, thanks!

Isn't there also something that allows overwriting the colors of single notes? I might be mistaken. It could be interesting to just put the custom_json_data stuff directly in the websocket output :)

opl- commented 3 years ago

While implementing this I had a friend mention as a joke that putting it as part of beatmap should be fine unless some mod allows going through all the colors of a rainbow. I hate that this joke turned out to be a reality. Completely forgot about Chroma.

I'll just say that for now the way the mod is written and the protocol designed makes it difficult to allow optional mods and extra data to be sent out over the WebSocket while keeping it reasonably clean and easy to use.

I'm not entirely opposed to exposing _customData as it would certainly be useful, especially for tinkering. I'll think about whether this is a good idea and if there's a decent solution for the changing environment colors problem.

codingcatgirl commented 3 years ago

Okay, no hurry! Thanks for your work so far <3

Protected commented 3 years ago

Ooo, now I have to actually make the widget I wanted. I'll let you know when I have a link for the list.

codingcatgirl commented 2 years ago

Since i'm just tinkering with this again, i felt like i might comment on here that this is still an open issue. Could be worth reopening it ^^