opnsense / core

OPNsense GUI, API and systems backend
https://opnsense.org/
BSD 2-Clause "Simplified" License
3.24k stars 722 forks source link

Add Ability to Save Filters in Firewall Live Log View #4859

Closed borkedporcupine closed 3 years ago

borkedporcupine commented 3 years ago

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.

This is a feature request, not related to a problem.

Describe the solution you like

On the firewall live log page, /ui/diagnostics/firewall/log I think it would be useful if we could save filters for common filtering tasks. I find myself doing repetitive tasks when digging through logs, would like to be able to save the filters for quick filtering.

Describe alternatives you considered

Alternative is a manually choosing filters each time.

Additional context

Something like this is what I would like to see (down toward the bottom) https://campus.barracuda.com/product/webapplicationfirewall/doc/78810008/types-of-logs/

AdSchellevis commented 3 years ago

https://github.com/opnsense/core/issues/4731 sounds quite similar, since this template is more complete, I'll close the other one.

kulikov-a commented 3 years ago

Hello everyone! did I get the idea right? (grid-MVC for templates storing. quick manipulation directly on Live View)

https://user-images.githubusercontent.com/36099472/113257088-c290f780-92d2-11eb-9f44-a3d9420967cf.mp4

borkedporcupine commented 3 years ago

Hello everyone! did I get the idea right? (grid-MVC for templates storing. quick manipulation directly on Live View)

lv-templ.mp4

@kulikov-a This looks fantastic.

kulikov-a commented 3 years ago

Thanks! then i continue with this approach) I did not plan any other functions so as not to clutter up the interface (even editing is not planned: "select->modify->del->add with old name" are enough imho)<-upd. or maybe not) please tell if something is missing

kulikov-a commented 3 years ago

Hi everyone. Me again. All functions are ready, template editing is added. If there are no other suggestions and comments, then I'm ready to clean up the code and prepare a pr.

https://user-images.githubusercontent.com/36099472/113511741-21bc6980-956a-11eb-9ae7-445a275b8fd0.mp4