opnsense / core

OPNsense GUI, API and systems backend
https://opnsense.org/
BSD 2-Clause "Simplified" License
3.36k stars 754 forks source link

Reporting - Unbound DNS - Logarithmic scale save #6271

Closed T13nou closed 1 year ago

T13nou commented 1 year ago

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

Hi,

When I'm going to "Reporting > Unbound DNS" I can check the boxes "Logarythmic" but it doesn't save this setting.

If I navigate in other tabs and come back to "Reporting > Unbound DNS", the checkbox is empty.

To Reproduce

Steps to reproduce the behavior:

  1. Go to "Reporting > Unbound DNS
  2. Click on "Logarythmic" checkbox
  3. It applies correctly
  4. Go to another menu and come back to "Reporting > Unbound DNS
  5. "Logarythmic" checkbox is empty

Expected behavior

I expect the checkbox to keep the "Logarythmic" checked and maybe a button save.

Describe alternatives you considered

Save button or equivalent

Environment

Software version used and hardware type if relevant, e.g.:

OPNsense 23.1 Intel NUC 11 Network Intel® I225

swhite2 commented 1 year ago

The best course of action would be to set it in the browsers' local storage so it's implicitly saved.

Thanks for the suggestion, will add this when I get around to it :)

T13nou commented 1 year ago

Thanks :)

swhite2 commented 1 year ago

Fixed in https://github.com/opnsense/core/commit/dd720b45b4bc4fcaea77e5e32ea356f886bee632