search

opnsense / core

OPNsense GUI, API and systems backend
https://opnsense.org/
BSD 2-Clause "Simplified" License
3.31k stars 738 forks source link

Kea log file search fails when search string contains ":" characters #7215

Closed jeffstearns closed 8 months ago

jeffstearns commented 8 months ago

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

The Kea log file page at .../ui/diagnostics/log/core/kea is broken. The Search box does not work as expected when the search string contains ":" characters.

To Reproduce

Steps to reproduce the behavior:

  1. Configure the Kea DHCP server and let it run until is serves some leases.
  2. Go to '.../ui/diagnostics/log/core/kea'
  3. Note that the log file looks similar to the log file shown below.
  4. Click in the Search box and enter any of the MAC addresses seen in the log file. For the example log file below, enter 44:61:32:d6:1d:5d
  5. Note that the page now shows "No results found!"
  6. Slowly delete characters from the text in the Search box. Note that no matches are displayed until the search text is reduced to just a few characters.
  7. Note that search strings like "DHCP4_LEASE_ALLOC" work as expected. The bug seems to be specific to search text containing the ":" character.

Expected behavior

When a search string contains multiple ":" characters, the result page displays all matching lines.

Describe alternatives you considered

I haven't found any workarounds.

Screenshots

Screenshot 2024-02-07 at 11.14.27 AM.pdf

Relevant log files

Date Severity Process Line .
2024-02-07T11:13:22-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_LEASE_ALLOC [hwtype=1 44:61:32:d6:1d:5d], cid=[ff:32:d6:1d:5d:00:03:00:01:44:61:32:d6:1d:5d], tid=0x258769e8: lease 10.5.1.109 has been allocated for 600 seconds  
2024-02-07T11:13:07-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_LEASE_ALLOC [hwtype=1 04:5d:4b:aa:87:b9], cid=[01:04:5d:4b:aa:87:b9], tid=0x159fe5f8: lease 10.5.1.178 has been allocated for 600 seconds  
2024-02-07T11:12:53-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_LEASE_ALLOC [hwtype=1 a8:b5:7c:49:58:eb], cid=[no info], tid=0x21643b6f: lease 10.5.1.100 has been allocated for 600 seconds  
2024-02-07T11:12:51-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_LEASE_ALLOC [hwtype=1 bc:24:11:a6:25:09], cid=[ff:11:a6:25:09:00:01:00:01:2d:30:5e:80:bc:24:11:ca:ca:2a], tid=0x86303a20: lease 10.5.1.230 has been allocated for 600 seconds  
2024-02-07T11:12:49-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_LEASE_ALLOC [hwtype=1 44:61:32:2f:c1:e5], cid=[ff:32:2f:c1:e5:00:03:00:01:44:61:32:2f:c1:e5], tid=0x21322d81: lease 10.5.1.234 has been allocated for 600 seconds  
2024-02-07T11:12:16-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_LEASE_ALLOC [hwtype=1 c8:e0:eb:3c:6e:43], cid=[01:c8:e0:eb:3c:6e:43], tid=0xb7c7b775: lease 10.5.1.110 has been allocated for 600 seconds  
2024-02-07T11:12:16-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_INIT_REBOOT [hwtype=1 c8:e0:eb:3c:6e:43], cid=[01:c8:e0:eb:3c:6e:43], tid=0xb7c7b775: client is in INIT-REBOOT state and requests address 10.5.1.110  
2024-02-07T11:11:38-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d1fd00] DHCP4_LEASE_ALLOC [hwtype=1 c0:56:e3:6f:42:95], cid=[01:c0:56:e3:6f:42:95], tid=0xe30c7536: lease 10.5.8.70 has been allocated for 600 seconds  
2024-02-07T11:10:57-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d20400] DHCP4_LEASE_ALLOC [hwtype=1 94:05:bb:10:16:58], cid=[01:94:05:bb:10:16:58], tid=0xb8b7280a: lease 10.5.1.113 has been allocated for 600 seconds  
2024-02-07T11:10:40-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d20400] DHCP4_LEASE_ALLOC [hwtype=1 90:03:b7:fa:2b:a5], cid=[01:90:03:b7:fa:2b:a5], tid=0x111fd258: lease 10.5.1.121 has been allocated for 600 seconds  
2024-02-07T11:10:36-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d20400] DHCP4_LEASE_ALLOC [hwtype=1 94:bf:2d:76:82:cd], cid=[01:94:bf:2d:76:82:cd], tid=0xe4ea1ee0: lease 10.5.1.105 has been allocated for 600 seconds  
2024-02-07T11:10:36-08:00 Informational kea-dhcp4 INFO [kea-dhcp4.leases.0x833d20400] DHCP4_INIT_REBOOT [hwtype=1 94:bf:2d:76:82:cd], cid=[01:94:bf:2d:76:82:cd], tid=0xe4ea1ee0: client is in INIT-REBOOT state and requests address 10.5.1.105  

Additional context

None.

Environment

OPNsense 24.1.1-amd64 FreeBSD 13.2-RELEASE-p9 OpenSSL 3.0.13

AdSchellevis commented 8 months ago

https://github.com/opnsense/core/commit/33894fc6a754b485be2989037bbc311a78eea467 should do the trick, install via:

opnsense-update 33894fc