MVC/Model - performance overhead when using "constraints"

[AdSchellevis]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• [x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• [x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

After implementing https://github.com/opnsense/core/commit/e36123c99f4ff2a518a927f1807be51186f78577 we seem to have quite some overhead of using standard constraints. Some of them (UniqueConstraint) cause loops in loops, which makes large lists hard to handle.

To Reproduce

1. In Firewall: Aliases add a couple of thousand items
2. Edit one and save --> takes seconds to process

Expected behavior

Persisting the data in less than a second.

Describe alternatives you considered

None

Additional context

One of the main culprits seems to be the back reference in the following code:

https://github.com/opnsense/core/blob/79312f47eabd8d55eb776dc6f25bd19d911e0e5e/src/opnsense/mvc/app/models/OPNsense/Base/Constraints/UniqueConstraint.php#L73

Environment

Software version used and hardware type if relevant, e.g.:

OPNsense 24.1.8 (amd64).