opnsense / core

OPNsense GUI, API and systems backend
https://opnsense.org/
BSD 2-Clause "Simplified" License
3.29k stars 735 forks source link

System picture deleted by saving again #7940

Open itkfm opened 6 hours ago

itkfm commented 6 hours ago

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

After setting a Picture in System › Settings › General and saving the picture is set as expected. But saving that page again (with no change to the picture) deletes the picture.

To Reproduce

Steps to reproduce the behavior:

  1. Goto System › Settings › General.
  2. Click on the picture selector and upload a picture by pressing [Save].
  3. The settings page confirms the changes and shows the uploaded picture.
  4. Press [Save] again.
  5. The settings page confirms the changes and the previously uploaded picture is gone.

Expected behavior

The uploaded picture stays in place.

Describe alternatives you considered

Not using the new Picture widget.

Screenshots

Relevant log files

n/a

Additional context

n/a

Environment

itkfm commented 6 hours ago

Picture is a PNG-8 file.

Also tested it with JPEG – The one in the screenshots is a JPG file.