search

opnsense / plugins

OPNsense plugin collection
https://opnsense.org/
BSD 2-Clause "Simplified" License
832 stars 620 forks source link

GUI > Routing: No config option to add "default-information originate" to the OSPFv3 configuration #3519

Closed FailedWOF closed 1 year ago

FailedWOF commented 1 year ago

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

Missing configuration option in the GUI. No option to add default-information originate [always] [metric] to the frr config from the OSPFv3 configuration GUI

Plugin: os-frr GUI: Routing > OSPFv3

In frr 7.5.1 it appears that IPv6 default gateway distribution may be picked up implicitly by specifying default-information originate in the router ospf config block through the OSPF GUI pages.

In 23.1 with frr 7.5.1 the default-information originate command doesn't exist under router ospf6, but ospf6d will distribute the IPv6 default gateway if default-information originate is specified in the router ospf config block.

After upgrading to 23.7 (which upgrades to frr-8.5), default gateway distribution must be explicit defined for both under both router ospf and router ospf6.

Adding via vtysh solves the IPv6 default route distribution problem, but does not persist.

To Reproduce

Steps to reproduce the behavior:

  1. OPsense 23.7
  2. Install plugin os-frr
  3. Routing > OSPFv3 > General
  4. No Advertise Default Gateway or Always Advertise Default Gateway checkboxes, and no Advertise Default Gateway Metric field (or other methods) to add the default-information originate [always] [metric] command to the router ospf6 config block

Expected behavior

Advertise Default Gateway and Always Advertise Default Gateway checkboxes, and Advertise Default Gateway Metric field that will add default-information originate [always] [metric] to the router ospf6 config block.

Describe alternatives you considered

Uninstalling os-frr and installing frr as a manual package then configuring through the CLI directly with vtysh gets around the persistence issue. However, this removes the useful GUI diagnostics and would be a temporary workaround rather than a permanent fix.

Screenshots

N/A

Relevant log files

N/A

Additional context

The default-information originate command for ospf6 was added to frr-8.0 in March 2021 - https://github.com/FRRouting/frr/pull/8057

Overall it looks like there needs to be a review and some rewrites of the Routing GUI pages with the update of the OPNsense plugin to frr-8.5 as the frr conf file is now very different. But I can appreciate that's a bigger task.

Environment

OPNsense 23.7 (amd64, OpenSSL). frr8.5 (os-frr 1.34)

kathampy commented 1 year ago

I have the same issue. I use OPNsense's DHCPv6 server to delegate a prefix to an L3 switch using a link-local transit network (no DHCPv6-assigned address or SLAAC on the L3 switch). I use OSPFv3 to advertise the delegated prefix from the L3 switch back to OPNsense (since a route to the delegated prefix does not get installed in OPNsense if the L3 switch doesn't request a DHCPv6-assigned address).

Since I don't use SLAAC on the transit network, there is no default route installed on the L3 switch either. I want to use OSPFv3 to advertise the default gateway to the L3 switch, but the option is missing as the bug report says.

imjustmatthew commented 1 year ago

Same issue. In general the OSPFv3 GUI really needs some love or a way to just add extra config options.

AdSchellevis commented 1 year ago

@imjustmatthew as emailed, https://github.com/opnsense/plugins/pull/3575 contains the proposed changes. To test on the current version, use:

opnsense-patch -c plugins a1138ec
imjustmatthew commented 1 year ago

Thanks! That patched worked for me on 23.7.3 with no negative impacts.

I tested with Brocade L3 switches if that matters to anyone else following this.

AdSchellevis commented 1 year ago

Merged in https://github.com/opnsense/plugins/commit/a477a672a582ef57f6bad65c82f1064c334dbfbe including revision and model update as reported by @mimugmail