search

opnsense / plugins

OPNsense plugin collection
https://opnsense.org/
BSD 2-Clause "Simplified" License
810 stars 593 forks source link

ACME certificates command column too narrow, os-theme-cicada & os-theme-rebellion #3816

Open Taomyn opened 4 months ago

Taomyn commented 4 months ago

Important notices Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug The two themes, cicada and rebellion, do not format the command column in ACME certificates, and it's too narrow to easily use the final commands. For the standard opnsense theme it's fine

I think it would be great if throughout the OPNsense GUI that columns could simply be adjustable and re-ordered as often even removing a column ends up with the wrong ones getting re-sized, which is the case for the one I'm reporting. Perhaps a future enhancement, but for now simply being able to quickly tap the delete icon would be great, as trying to move the mouse to just the right part of the "..." is tricky.

To Reproduce Steps to reproduce the behavior:

  1. Change theme to either cicada or rebellion
  2. Go to ACME, Certificates
  3. Final commands column is truncated

Expected behavior Format the commands column like the opnsense theme

Screenshots image image

Relevant log files n/a

Additional context I'm normally using Brave browser, but Edge does the same.

Environment OPNsense 24.1.1-amd64 FreeBSD 13.2-RELEASE-p9 OpenSSL 3.0.13 image

fraenki commented 4 months ago

@marjohn56 @opnsenseuser Could you probably have a look at this? The "command" column is somewhat crowded in os-acme-client... :blush:

opnsenseuser commented 4 months ago

@marjohn56

ok found the problem. I compared the working main.css from opnsense/vicuna theme with the main.css from cicada and found the problem.

.btn-xs, .btn-group-xs > .btn { padding: 1px 4px; }

on every other theme i made there are no problems. (tukan, vicuna)

opnsenseuser commented 4 months ago

@marjohn56 i fixed it for theme rebellion too.

marjohn56 commented 4 months ago

Hi,

Just about to do it this morning and then I read your email!

Thank you very much.😊

KR

Martin

From: René @.> Sent: 23 February 2024 21:57 To: opnsense/plugins @.> Cc: Martin Wasley @.>; Mention @.> Subject: Re: [opnsense/plugins] ACME certificates command column too narrow, os-theme-cicada & os-theme-rebellion (Issue #3816)

@marjohn56https://github.com/marjohn56 i fixed it for theme rebellion too.

— Reply to this email directly, view it on GitHubhttps://github.com/opnsense/plugins/issues/3816#issuecomment-1962055056, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEJBPJSOZTLVLLGEX4OP5Y3YVEGDLAVCNFSM6AAAAABDEXW4SSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGA2TKMBVGY. You are receiving this because you were mentioned.Message ID: @.**@.>>

opnsenseuser commented 4 months ago

https://github.com/opnsense/plugins/pull/3843