opnsense / plugins

OPNsense plugin collection
https://opnsense.org/
BSD 2-Clause "Simplified" License
810 stars 593 forks source link

dns/bind: Fix handling of multiple ACLs in allow-query/allow-transfer #4048

Closed NHellFire closed 1 week ago

NHellFire commented 1 week ago

Selecting multiple ACLs under the General tab currently results in invalid config:

        allow-transfer {
                ;
        };

        allow-query {
                ;
        };

This corrects the behaviour:

        allow-recursion {
                LAN;
                VPN;
        };

        allow-query {
                LAN;
                VPN;
        };
fichtner commented 1 week ago

Nice catch... toList() is supposed to be used for repeating nested items, not single value items. Thanks!