opnsense / plugins

OPNsense plugin collection
https://opnsense.org/
BSD 2-Clause "Simplified" License
832 stars 617 forks source link

Bug report when enable Nginx after update 24.7 #4113

Closed netcedec closed 1 month ago

netcedec commented 1 month ago

Important notices Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug After upgrading to 24.7 a bug report appeared, nginx and waf naxsi logs are missing. When restarting the service, the bug report appears. Nginx itself proxies, but no more. The nginx and waf configurations have not been changed since the upgrade.

To Reproduce Steps to reproduce the behavior:

  1. Go to opnsense
  2. Click on update
  3. After update go in Loby -> Dashboard
  4. Add Widget "Services"
  5. Save widget
  6. Click on reload service "Reverse Proxy and Web Server"
  7. Go Services -> Nginx -> Logs / HTTP Access or HTTP Error

Expected behavior Service reload, there are logs in Nginx

Screenshots

image

image

Relevant log files In bug report

PHP Error:

[25-Jul-2024 18:08:57 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:08:58 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:09:04 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:09:06 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}
[25-Jul-2024 18:09:06 Europe/Moscow] Exception: Response Already Sent in /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Response.php:97
Stack trace:
#0 /usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php(356): OPNsense\Mvc\Response->send()
#1 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Dispatcher.php(167): OPNsense\Base\ApiControllerBase->afterExecuteRoute(Object(OPNsense\Mvc\Dispatcher))
#2 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(156): OPNsense\Mvc\Dispatcher->dispatch(Object(OPNsense\Mvc\Request), Object(OPNsense\Mvc\Response), Object(OPNsense\Mvc\Session))
#3 /usr/local/opnsense/mvc/app/library/OPNsense/Mvc/Router.php(139): OPNsense\Mvc\Router->performRequest(Object(OPNsense\Mvc\Dispatcher))
#4 /usr/local/opnsense/www/api.php(36): OPNsense\Mvc\Router->routeRequest('/api/nginx/logs...', Array)
#5 {main}

Additional context Add any other context about the problem here.

Environment Software version used and hardware type if relevant. e.g.:

OPNsense 24.7-amd64 Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz Network VMXNET 3

ivulit commented 1 month ago

Same issue here after upgrade. No access/error logs and got same issue report. os-nginx version is 1.34.

kulikov-a commented 1 month ago

can you test with opnsense-patch -c plugins -a kulikov-a a7ef2d9 (https://github.com/opnsense/plugins/commit/a7ef2d9a29e858d6700a81aab22417df9a1adb0c) please?

ivulit commented 1 month ago

can you test with opnsense-patch -c plugins -a kulikov-a a7ef2d9 (a7ef2d9) please?

Hi. i've applied this patch. Access/Error logs are available again and no any bug reports. Looks like patch solved this issue.

kulikov-a commented 1 month ago

@ivulit great! thanks, i'll clean it up and make a pr a little later

netcedec commented 1 month ago

can you test with opnsense-patch -c plugins -a kulikov-a a7ef2d9 (a7ef2d9) please?

Thanks! It's work!!!!!!!!!

ivulit commented 1 month ago

@kulikov-a Thanks a lot for quick response!

GitTimeraider commented 1 month ago

Can also confirm the update command fixes it. Hopefully it gets through into the next update so everyone can have it forced through :P

OoSTARTERoO commented 1 month ago

quick and easy fix! thanks!

fichtner commented 1 month ago

It has been merged now but I missed this for 24.7.1. Sorry.