Closed agh1467 closed 2 years ago
fichtner
commented
2 years ago @agh1467 We have to park dnscrypt-proxy 2.0 somewhere else before we do this. We should probably have both plugins/packages in parallel for a while but really need to progress on the plugin /review front first.
L1ghtn1ng
commented
2 years ago @fichtner why do we need to have 2.0 along side 2.1? I submitted an issue a while back for things that are deprecated in the 2.1 release and @mimugmail fixed them so personally I do not see why we need to do it as they did throw deprecated warnings on the 2.0.45 release. We should be in good shape for the 2.1.x release. The only thing that would "need" doing is just exposing any new features for it in the plugin ui
fichtner
commented
2 years ago well @mimugmail is the maintainer and if it's easy to test just do it and let me know then we can make the switch. I was more referring to @agh1467's efforts to rewrite the plugin based on 2.1 which we can't simply switch for the old one.
L1ghtn1ng
commented
2 years ago Ah okay fair enough, makes more sense now
On 1 Feb 2022, at 14:17, Franco Fichtner @.***> wrote:
well @mimugmailhttps://github.com/mimugmail is the maintainer and if it's easy to test just do it and let me know then we can make the switch. I was more referring to @agh1467https://github.com/agh1467's efforts to rewrite the plugin based on 2.1 which we can't simply switch for the old one.
— Reply to this email directly, view it on GitHubhttps://github.com/opnsense/ports/pull/138#issuecomment-1026891286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3V2QVR2UGQZQNZF5X5ZC3UY7TP3ANCNFSM5K6TGELQ. You are receiving this because you commented.Message ID: @.***>
agh1467
commented
2 years ago With respect to my dnscrypt-proxy plugin re-write, I've got some thinking to do based on feedback I've received for https://github.com/opnsense/plugins/pull/2729 as some of the same approaches were used. It will be some time before I'll have something ready for review.
With respect to dnscrypt-proxy version upgrade, in my experience, the author provides warnings for deprecated configuration changes to allow for transition to new configuration names, so it shouldn't break things. And as @L1ghtn1ng stated, the new configuration options would has to be exposed in the UI. It would be nice if the plugin could move at the same time but shouldn't be necessary, however, testing should still be done first before doing the update just in case.
I'm not sure this is the correct procedure. This commit is cherry-picked from upstream https://github.com/freebsd/freebsd-ports/commit/4aa7636dd601758103798aef7ffb9c51f62aaf17 and udates dnscrypt-proxy2 to 2.1.1.