opnsense / ports

OPNsense ports on top of FreeBSD
https://opnsense.org/
Other
157 stars 112 forks source link

www/caddy-custom: Always builds latest version of caddy #197

Closed Monviech closed 2 months ago

Monviech commented 2 months ago

It seems like the port doesn't set an enviroment variable for xcaddy to pin the same version as used for the port of www/caddy.

It causes www/caddy-custom to always build latest, even though the plugin version is still called 2.7.6.x.x.x

Right now its building with 2.8.1 already, since xcaddy always pulls latest by default.

I already wanted to fix this once by implementing a version tag parameter: https://github.com/opnsense/ports/pull/190/commits/9ef120066346c97d4b41badcb9fe4ca1fecfecd1

Though this would have to be fixed properly upstream, so that the package version also reflects the built version properly.

Additional references: https://github.com/opnsense/tools/pull/400#issuecomment-2140805870

EDIT:

I'll do a PR that tries to fix it by using $(DISTVERSION)

Monviech commented 2 months ago

@fichtner https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279438