oppia / design-team

Workflow repo for the Oppia design team.
0 stars 1 forks source link

Multiple Classrooms (Android) #125

Open moewastaken opened 5 months ago

moewastaken commented 5 months ago

Platform Oppia Android

Describe the request Require UI designs based on the PRD to enable multiple classrooms in the Oppia App.

Context for the request This is a new feature. Currently, app learners are limited to a single subject (math). "Classrooms" will allow the development and consumption of content across multiple subjects. Please see the PRD for details.

Link to PRD https://docs.google.com/document/d/1uOiDnWBxJmDMwqej-VSRKEnDP4Been3np9y1ov6YTNA/edit#heading=h.liiqbmwmz8j8

Information about deadlines/priorities

Targeted for design completion by Q1 2024.

Note: please consider collaborating with the Android team designer on the corresponding Android issue: #109

DESIGN APPROVAL CHECKLIST -- DO NOT EDIT.

For a design project to be completed, it needs approval from UXD, UXW, DS and PM. Please tag the following reviewers when your project is ready (at least one reviewer for each of the 4 bullet points below):

aayush0982 commented 5 months ago

@seanlip Could you please confirm whether this matter involves any coding? If not, may I kindly request to be assigned to handle it?

seanlip commented 5 months ago

@aayush0982 The designs aren't created yet so this isn't ready for coding. If you are looking for Android projects, please see github.com/oppia/oppia-android instead.

aayush0982 commented 5 months ago

@seanlip No I mean if it is not related to coding , can you assign this to me?

aayush0982 commented 5 months ago

@seanlip just I need to know more clearly about teacher part in app As I have downloaded the app and understand what you want for a student

aayush0982 commented 5 months ago

@seanlip but as I tried to set up profile as a teacher , I don't found any option so please tell that if this app contain profile for teacher or I have to create design for it, if this project will be assigned to me

seanlip commented 5 months ago

Hi @aayush0982, design issues are only available to be taken by members of the design team. If you would like to apply for non-coding volunteer positions at Oppia, please fill in the form at www.oppia.org/volunteer . Thanks.

aayush0982 commented 5 months ago

Hi @seanlip , I wanted to bring to your attention that I have completed the form as instructed earlier; however, I haven't received a response yet. Could you please take a moment to look into this matter?

seanlip commented 5 months ago

@aayush0982 I'll connect you with Angie, our volunteer coordinator, who can follow up.

aayush0982 commented 5 months ago

@seanlip Ok

seanlip commented 3 weeks ago

Current Figma file: https://www.figma.com/file/l3wNKY9RkBhwHcydNqZn4Z/Oppia-Multiple-Classroom-Android?type=design&node-id=0%3A1&mode=design&t=oTn1pm8cTJd1a5CW-1

ashley-ya commented 2 weeks ago

[design decision notes] from meeting yesterday, design decision surrounding multiple classroom layout pattern was driven by a focus on minimizing the amount of classrooms a user could look at at once. The bulk of the users attention would be on looking at the classroom topics anyway.

ashley-ya commented 1 week ago

Hi, looking to verify a new design style with the design systems team.

@qluuu and @celestinetales, I want to have a darker background for the selected tab options and am proposing we use darker shades for the card text and card background. [screenshot attached]

when looking at the design style guide, we don't appear to have an existing style for this type of card. let me know if my proposal is alright or if i need to align the style to something else. the changes to the background color and text color help differentiate the selected tab state, and also provide WCAG AAA accessibility.

reference material: https://www.figma.com/design/G0jHrMaopFzk2ZksuynBjS/Android-style-guide?node-id=2-8412&t=kpjeAoNUVacwWgBM-1

Screenshot 2024-07-03 at 10 16 20 AM
qluuu commented 3 days ago

Thanks for reaching out @ashley-ya I definitely agree with you that the darker color would aid in accessibility. As a food for thought, will you be considering the use of bolding the text as a secondary indicator for highlighting the tab?

As for the android style guidance, I think it would be good to add to the design system in a formal way. Please create an annotation on your figma file with a note on use cases and guidance. During your handoff phase, please kindly flag the design system team in your communications to ensure that it gets added to the file.

(We are still in the process of developing a good 'way of working' to ensure that new changes get added to the design system.) I think this is a conversation that we can sync on between the design systems team and the android team. Let me know your thoughts. :)

ashley-ya commented 1 day ago

@qluuu thanks for the feedback! I agree, I think a closer collaboration between the design systems and android team can be a great experience for both teams! I was thinking about trying to change the font weight as well, but the font we are using only has one weight setting.

Will make sure to set up a hand off between designs systems once these designs are finalized.