search

oppia / design-team

Workflow repo for the Oppia design team.
0 stars 1 forks source link

Figma design issue on Footers #148

Closed smtirike02 closed 2 months ago

smtirike02 commented 7 months ago

Hi, In the Oppia.org's Figma I noticed that there's a collision on Footers section. Both components for footer and banners are unreadable making it confusing. I'd be happy to fix the issue if needed help!

Screenshot 2024-04-12 at 15 35 06

smtirike02 commented 7 months ago

Hi, any updates on this issue? @seanlip @dchen97

seanlip commented 7 months ago

Hi @smtirike02 I think this is a question for @qluuu and @celestinetales, who lead the design systems team. Looping them in. Thanks!

qluuu commented 7 months ago

@smtirike02 @seanlip Thanks for looping us in! Yes, the readability is definitely an issue. As this the Aug 2023 Design System File, I don't have edit access to this file. Would be happy to edit if granted access.

Also, @seanlip, as the new design system file gets more pages finalized, it would be helpful to make a note on this Aug 2023 file to point designers/dev to the new file as well.

seanlip commented 7 months ago

Hi @qluuu, you are now an editor of the file. Please feel free to make the necessary changes. @celestinetales is the owner so please reach out to both of us if you run into any issues.

Also, we should update the links at https://github.com/oppia/design-team to point to the canonical reference. Could you please tell me if an update is needed there, and if so, what the new link(s) should be?

Thanks!

qluuu commented 7 months ago

@seanlip Thanks for adding me. I'll work on this #148 Footers project edits at the end of the week.

Re: canonical reference, yes we can update it soon. But since our new design system is still very much a work in progress, I think first we need to paste all the items from the old file that we haven't worked on yet (items still in status quo) into our new canonical file and put appropriate status annotations (e.g., "Most current version: Please use this version in your designs, MM/DD/YYYY") to ensure that anyone looking at the file isn't confused. I anticipate this to be a fairly quick process. Let me know what you think. Thanks!

seanlip commented 7 months ago

@qluuu Hmm, what do you think about just treating the existing reference as the canonical one, and updating it as needed? And, any approach that enables designers to know what to do and what they can rely on as solid works for me. Perhaps this is something worth discussing with the team?

qluuu commented 7 months ago

@seanlip The existing reference has all design system info on one page. In our new system template, the structure is different. We have separate pages for different assets so that it's easier to load and so that designers can find things easily. I can definitely discuss with team on Monday and loop you in during the Leads meeting.

seanlip commented 5 months ago

@qluuu Do you know what the next steps are for this issue? The comment above said that you would follow up after discussing with the team, but I am not sure what the outcome of the discussion is.

qluuu commented 5 months ago

@seanlip Hi Sean, according to the team, they refer to both the 2023 design system and the new template when designing and that it was useful to see what the past design system looks like, especially as we are still updating sections the new template. In terms of record keeping, it was useful to see how the design system has evolved.

Based on this, for the new template, I've pasted the relevant frames from the Aug 2023 design system file into our new template version with clear labeling that "this is the 2023 version that is still in use while we are pending updates". In the case of sections that have been updated (e.g., typography) I've included a note saying, in essence, "this is updated 2024 version and is currently in use for UX designers." I just need to run this format by the team to get their final thoughts.

seanlip commented 5 months ago

Sounds good, thanks @qluuu. In that case, let's try and standardize on a single source of truth as discussed in the design leads meeting -- feel free to update this issue once we have a confirmed canonical-source-of-truth file, so that we can make sure we reflect it in all our documentation, and then close this issue.

Thanks!

qluuu commented 2 months ago

@seanlip Just to follow-up here with a comment for record keeping. This issue can indeed be closed. The overlap of text was fixed in the old design system file (Aug 2023 Design System Figma File) and this change is also reflected in the new design system file.

seanlip commented 2 months ago

Great, thanks @qluuu! Closing this then.